Skip to content

release-21.2: backupccl: disable multi-region TestRestoreOldVersions under race#71389

Merged
otan merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-71382
Nov 15, 2021
Merged

release-21.2: backupccl: disable multi-region TestRestoreOldVersions under race#71389
otan merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-71382

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Oct 11, 2021

Backport 1/1 commits from #71382 on behalf of @otan.

/cc @cockroachdb/release

Release note: None

Release justification:

@blathers-crl blathers-crl bot requested review from a team and dt and removed request for a team October 11, 2021 05:15
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-71382 branch from 245bd61 to fbd543f Compare October 11, 2021 05:15
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Oct 11, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Oct 11, 2021

This change is Reviewable

@dt
Copy link
Copy Markdown
Contributor

dt commented Oct 11, 2021

nit: s/Resolve/Restore/

@otan otan changed the title release-21.2: backupccl: disable multi-region TestResolveOldVersions under race release-21.2: backupccl: disable multi-region TestRestoreeOldVersions under race Oct 13, 2021
@otan otan changed the title release-21.2: backupccl: disable multi-region TestRestoreeOldVersions under race release-21.2: backupccl: disable multi-region TestRestoreOldVersions under race Oct 13, 2021
@otan otan merged commit 53bb848 into release-21.2 Nov 15, 2021
@otan otan deleted the blathers/backport-release-21.2-71382 branch November 15, 2021 20:05
@celiala celiala mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dt dt Awaiting requested review from dt

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde

@shermanCRL shermanCRL Awaiting requested review from shermanCRL

Assignees

@otan otan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cockroach-teamcity @dt @otan