storage: always close iterators, batches in unit tests#71303
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 8, 2021
Merged
storage: always close iterators, batches in unit tests#71303craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
sumeerbhola
approved these changes
Oct 8, 2021
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Thanks!
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
This fixes a handful of instances where iterators and batches either weren't closed, or weren't closed if the test failed because the Close wasn't deferred. There are more in the codebase, but I wanted to break this up a bit since some of them are trickier to track down. Release note: None
2845170 to
fbb6e56
Compare
jbowens
commented
Oct 8, 2021
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a handful of instances where iterators and batches either
weren't closed, or weren't closed if the test failed because the Close
wasn't deferred.
There are more in the codebase, but I wanted to break this up a bit
since some of them are trickier to track down.
Release note: None