multiregionccl: deflake TestMultiRegionDataDriven/regional_by_table#70847
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 28, 2021
Merged
Conversation
Member
|
This change is |
This was missing a call to refresh the range descriptor cache before issuing a request to a RBT table. We recenlty improved tracing around range descriptor cache lookups, and as such, the "dist sender send" message associated with this lookup was getting caught in the query trace which made the test unhappy. We circumvent this problem by refreshing the range descriptor cache before running the query we plan on tracing. Stressed this for 20 minutes and it ran fine. Closes cockroachdb#70846 Release note: None
3e92cfc to
d170ab0
Compare
otan
approved these changes
Sep 28, 2021
Collaborator
Author
|
Thanks! bors r=otan |
Contributor
|
Build succeeded: |
Contributor
|
blathers backport 21.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing a call to refresh the range descriptor cache before
issuing a request to a RBT table. We recenlty improved tracing around
range descriptor cache lookups, and as such, the "dist sender send"
message associated with this lookup was getting caught in the query
trace which made the test unhappy. We circumvent this problem by
refreshing the range descriptor cache before running the query we plan
on tracing.
Stressed this for 20 minutes and it ran fine.
Closes #70846
Release note: None