Skip to content

release-21.2: tenantcostclient: deflake TestDataDriven#70844

Merged
RaduBerinde merged 1 commit intocockroachdb:release-21.2from
RaduBerinde:backport21.2-70748
Sep 30, 2021
Merged

release-21.2: tenantcostclient: deflake TestDataDriven#70844
RaduBerinde merged 1 commit intocockroachdb:release-21.2from
RaduBerinde:backport21.2-70748

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde commented Sep 28, 2021

Backport 1/1 commits from #70748.

/cc @cockroachdb/release

Deflaking test by adding more timers clauses - these ensure that
quotapool timers are set up before advance.

Release note: None

Release justification: test-only change.

@RaduBerinde
tenantcostclient: deflake TestDataDriven
0298fb5 
Deflaking test by adding more `timers` clauses - these ensure that
quotapool timers are set up before `advance`.

Release note: None

Release justification: test-only change.
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 28, 2021 •
edited by RaduBerinde
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 28, 2021

This change is Reviewable

andy-kimball
andy-kimball approved these changes Sep 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@andy-kimball andy-kimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@RaduBerinde RaduBerinde mentioned this pull request Sep 30, 2021
Closed
15 tasks
@RaduBerinde RaduBerinde merged commit 96ed5b7 into cockroachdb:release-21.2 Sep 30, 2021
@RaduBerinde RaduBerinde deleted the backport21.2-70748 branch September 30, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy-kimball andy-kimball andy-kimball approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RaduBerinde @cockroach-teamcity @andy-kimball