sql: include ON UPDATE on CREATE TABLE LIKE for INCLUDING DEFAULTS#70472
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 21, 2021
Merged
sql: include ON UPDATE on CREATE TABLE LIKE for INCLUDING DEFAULTS#70472craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rafiss
requested changes
Sep 21, 2021
| h INT8 NULL, | ||
| j JSONB NULL, | ||
| k INT8 NULL, | ||
| t TIMESTAMPTZ NULL ON UPDATE current_timestamp():::TIMESTAMPTZ, |
Collaborator
There was a problem hiding this comment.
i'd be fine keeping this one. i vote we just decide now that INCLUDING DEFAULTS will also copy ON UPDATE. but then one thing to check is that a column with both DEFAULT and ON UPDATE is copied correctly
Contributor
Author
There was a problem hiding this comment.
i've changed this to be for DEFAULTS because ALL is a bitmask meaning including it on every option. i'm a bad proofreader.
Release note (sql change): CREATE TABLE ... LIKE ... now copies ON UPDATE definitions for INCLUDING DEFAULTS.
rafiss
approved these changes
Sep 21, 2021
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
lgtm!
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan and @rafiss)
Contributor
Author
|
bors r=rafiss |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #69258
Release note (sql change): CREATE TABLE ... LIKE ... now copies ON
UPDATE definitions for INCLUDING DEFAULTS.