Skip to content

ui: updates the jobs table styling#70374

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:jobs-page
Sep 20, 2021
Merged

ui: updates the jobs table styling#70374
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:jobs-page

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves #70149

Before
Screen Shot 2021-09-17 at 3 35 04 PM

After
Screen Shot 2021-09-17 at 3 35 52 PM

Release note (ui change): Updating job table style to
match all other tables on the console.

@maryliag maryliag requested a review from a team September 17, 2021 19:37
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves cockroachdb#70149

Release note (ui change): Updating job table style to
match all other tables on the console and also  update column name
from `Users` to `User`.
Copy link
Copy Markdown
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 !!!

Just curious, I didn't see any CSS change, so was it the original styling issues caused by the tooltips?

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @matthewtodd)

Copy link
Copy Markdown
Contributor Author

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different component: now it's using SortedTable from cluster-ui, instead of the one from a more generic component
And then I added the tooltip components on the header of each column

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @matthewtodd)

@maryliag
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 20, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 20, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update table visuals of job page

4 participants