pgcode: use XC instead of CDB#70347
Conversation
|
This change is |
knz
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan and @rafiss)
pkg/sql/pgwire/pgcode/codes.go, line 383 at r1 (raw file):
InternalConnectionFailure = MakeCode("58C01") // Class XCR - cockroach extension.
Classes are two characters. Make this "XC"
pkg/sql/pgwire/pgcode/codes.go, line 388 at r1 (raw file):
// UnsatisfiableBoundedStaleness signals that the bounded staleness query // cannot be satisfied. UnsatisfiableBoundedStaleness = MakeCode("XCR00")
"XCUBS"?
Release note (sql change): Change the pgerror code XC instead of CD for CockroachDB specific errors. This is because the "C" class is reserved for the SQL standard. The pgcode `CDB00` used for unsatisfiable bounded staleness is now `XCUBS`.
otan
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pgwire/pgcode/codes.go, line 383 at r1 (raw file):
Previously, knz (kena) wrote…
Classes are two characters. Make this "XC"
Done.
pkg/sql/pgwire/pgcode/codes.go, line 388 at r1 (raw file):
Previously, knz (kena) wrote…
"XCUBS"?
Done.
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status:
|
thanks for catching! bors r=knz |
|
Build succeeded: |
Release note (sql change): Change the pgerror code XC instead of CD
for CockroachDB specific errors. This is because the "C" class is
reserved for the SQL standard. The pgcode
CDB00used forunsatisfiable bounded staleness is now
XCUBS.