ui: add column selector to transation page#70262
ui: add column selector to transation page#70262craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
matthewtodd
left a comment
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
Azhng
left a comment
There was a problem hiding this comment.
Reviewed 2 of 11 files at r1.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx, line 41 at r1 (raw file):
rowsRead: "Rows Read", statements: "Statements", statementsCount: "Statements",
statements and statementsCount have the same column label ?
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx, line 588 at r1 (raw file):
); }, statementsCount: (statType: StatisticType) => {
Do we also want to annotate the return types here like we did for other places in this PR ?
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx, line 41 at r1 (raw file):
Previously, Azhng (Archer Zhang) wrote…
statementsandstatementsCounthave the same column label ?
same column label, different tooltip. That's why they need to be different keys here
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx, line 588 at r1 (raw file):
Previously, Azhng (Archer Zhang) wrote…
Do we also want to annotate the return types here like we did for other places in this PR ?
the return type here is a little trickier, we're returning as Element, but is we add return type Element it requires several other parameters, so I made the decision of leaving those one as is
Add column selector to Transaction Page Fixes cockroachdb#70148 Release justification: Category 4 Release note (ui change): Add column selector to transaction page
926ef9c to
662c466
Compare
Azhng
left a comment
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 662c466 to blathers/backport-release-21.2-70262: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Add column selector to Transaction Page
Fixes #70148
Release justification: Category 4
Release note (ui change): Add column selector to transaction page