Skip to content

ccl/backupccl: skip TestRestoreOldVersions#70155

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:skip-test-TestRestoreOldVersions
Sep 14, 2021
Merged

ccl/backupccl: skip TestRestoreOldVersions#70155
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:skip-test-TestRestoreOldVersions

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Sep 13, 2021

Refs: #70154

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

@jbowens
ccl/backupccl: skip TestRestoreOldVersions
05dcc30 
Refs: cockroachdb#70154

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@jbowens jbowens requested review from a team and dt and removed request for a team September 13, 2021 19:58
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 13, 2021

This change is Reviewable

@jbowens jbowens requested a review from nkodali September 13, 2021 22:34
@ajwerner
Copy link
Copy Markdown
Contributor

ajwerner commented Sep 13, 2021

My sense is that we should be marking these flaky tests as release blockers. This test matters quite a bit.

@irfansharif
Copy link
Copy Markdown
Contributor

irfansharif commented Sep 13, 2021

@ajwerner we used to chase down all skipped tests during our release process and ask teams to sign off on them ( skipped-test ). Is that something we still do?

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Sep 13, 2021

TFTR!

bors r=irfansharif

@ajwerner
Copy link
Copy Markdown
Contributor

ajwerner commented Sep 13, 2021

@ajwerner we used to chase down all skipped tests during our release process and ask teams to sign off on them ( skipped-test ). Is that something we still do?

You tell me?

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 14, 2021

Build succeeded:

@craig craig bot merged commit 19b1766 into cockroachdb:master Sep 14, 2021
@JuanLeon1
Copy link
Copy Markdown
Contributor

JuanLeon1 commented Sep 14, 2021

In theory we no longer chase anyone for the release process. If blockers remain by the SHA deadline, we abandon the release.

@jbowens jbowens deleted the skip-test-TestRestoreOldVersions branch September 14, 2021 12:56
@ajwerner
Copy link
Copy Markdown
Contributor

ajwerner commented Sep 14, 2021

In theory we no longer chase anyone for the release process. If blockers remain by the SHA deadline, we abandon the release.

The problem with that is that there's nothing marking these skipped tests as blockers!

@celiala celiala mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dt dt Awaiting requested review from dt

@nkodali nkodali Awaiting requested review from nkodali

1 more reviewer

@irfansharif irfansharif irfansharif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jbowens @cockroach-teamcity @ajwerner @irfansharif @JuanLeon1