roachtest: make --workload optional#70059
Conversation
|
This change is |
There was a problem hiding this comment.
i think some roachtest invocations rely on not specifying a workload binary flag, in which case findBinary would look in the "default places" for the workload binary. in other words, this would break invocations such as bin/roachtest run tpcc/multiregion/survive=region/chaos=true which relies on findBinary to find the "default" locations.
seems like a gotcha to me, maybe --skip-workload-binary if we don't want it included? or have an object that keeps track of whether the workload binary was initialised, and when we try scp that binary across then we panic? or maybe more effort than it's worth.
|
+1, findBinary also provides the default value (for better or worse), how about reverting to the old code but then return a sentinel error instead of this one cockroach/pkg/cmd/roachtest/cluster.go Line 181 in 6b89733 and then here cockroach/pkg/cmd/roachtest/cluster.go Lines 207 to 211 in 6b89733 you detect that error and print something like " |
148821d to
cbe6a9c
Compare
|
I see, thanks for the additional context. I've made the suggestions @tbg suggested. |
This commit makes the `--workload` flag optional because some roachtests do not require a workload binary. Release note: None
cbe6a9c to
aae7c56
Compare
tbg
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker and @otan)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit makes the
--workloadflag optional because some roachtestsdo not require a workload binary.
Release note: None