Skip to content

release-21.2: build: disable required release justifications#69984

Merged
celiala merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-69968
Sep 11, 2021
Merged

release-21.2: build: disable required release justifications#69984
celiala merged 1 commit intorelease-21.2from
blathers/backport-release-21.2-69968

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Sep 9, 2021 •
edited by celiala
Loading

Backport 1/1 commits from #69968 on behalf of @celiala.

/cc @cockroachdb/release

release-21.2 is cut.

Release note: None

Release justification: non-production code changes

@celiala
build: disable required release justifications
e2708ab 
release-21.2 is cut.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 9, 2021 19:30
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-69968 branch from 671906f to e2708ab Compare September 9, 2021 19:30
@blathers-crl blathers-crl bot requested a review from jlinder September 9, 2021 19:30
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Sep 9, 2021 •
edited by jlinder
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 9, 2021

This change is Reviewable

@celiala celiala merged commit 4811bb9 into release-21.2 Sep 11, 2021
@celiala celiala deleted the blathers/backport-release-21.2-69968 branch September 11, 2021 02:50
@celiala celiala mentioned this pull request Sep 27, 2021
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlinder jlinder jlinder approved these changes

Assignees

@celiala celiala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cockroach-teamcity @jlinder @celiala