metric: fix missing mutex handling in metrics registry#69538
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 29, 2021
Merged
metric: fix missing mutex handling in metrics registry#69538craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
I think we just forgot to lock in some places. I tested |
RaduBerinde
approved these changes
Aug 28, 2021
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz)
RaduBerinde
approved these changes
Aug 28, 2021
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Hm, the metric package timed out, deadlock?
Reviewable status:
Contributor
Author
|
doh, yeah it's the change in the test file, the methods that invoke |
This change ensures that the registry locks and unlocks whenever accessing its shared fields. Fixes: cockroachdb#69522 Release note: None Release justification: bug fixes and low-risk updates to new functionality
41dedfe to
0d750c6
Compare
Member
|
bors r+ |
Contributor
|
Build succeeded: |
Contributor
|
@adityamaru does this need a backport as well? |
Contributor
Author
|
Yeah you're right, it does. Labelling it so that I can open one once this bakes. |
This was referenced Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the metrics registry locks and unlocks
whenever accessing its shared fields.
Fixes: #69522
Release note: None
Release justification: bug fixes and low-risk updates to new functionality