sql: change plan_hash in system.statement_statistics from Int to Bytes#69502
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 28, 2021
Merged
sql: change plan_hash in system.statement_statistics from Int to Bytes#69502craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
reviewed
Aug 27, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Starting monday I don't think you can change the structure of this table. Even this is getting pretty tight.
Reviewable status:
complete! 0 of 0 LGTMs obtained
ajwerner
approved these changes
Aug 27, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
maryliag
approved these changes
Aug 27, 2021
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
Contributor
Author
|
Sorry for the last minute PR. bors r=maryliag,ajwerner |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
6e4bd51 to
069b590
Compare
Previously, `plan_hash` column in {crdb_internal,system}.statement_statistics
has the type Int. However, since `plan_hash` behaves with more
blob-like nature, Bytes is a more suitable data type.
This commit change the column type for plan hash to Bytes.
Release justification: Category 2: Bug fixes and low-risk updates to
new functionality
Release note (sql change): plan_hash column in both
system.statement_statistics and crdb_internal.statement_statistics
is changed from Int to Bytes.
069b590 to
964285a
Compare
Contributor
Author
|
Merge skew :/ bors r=maryliag,ajwerner |
24 tasks
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
plan_hashcolumn in {crdb_internal,system}.statement_statisticshas the type Int. However, since
plan_hashbehaves with moreblob-like nature, Bytes is a more suitable data type.
This commit change the column type for plan hash to Bytes.
Release justification: Category 2: Bug fixes and low-risk updates to
new functionality
Release note (sql change): plan_hash column in both
system.statement_statistics and crdb_internal.statement_statistics
is changed from Int to Bytes.