Skip to content

roachtest/follower-reads: adopt bounded staleness reads#69489

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/boundedStalenessRoachtest
Aug 30, 2021
Merged

roachtest/follower-reads: adopt bounded staleness reads#69489
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/boundedStalenessRoachtest

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Aug 27, 2021

This commit expands the existing follower-reads roachtest with four new variants:

  • follower-reads/survival=region/locality=global/reads=bounded-staleness
  • follower-reads/survival=region/locality=regional/reads=bounded-staleness
  • follower-reads/survival=zone/locality=global/reads=bounded-staleness
  • follower-reads/survival=zone/locality=regional/reads=bounded-staleness

As the names indicate, these four variants perform bounded staleness reads
over different cluster topologies and assert that the reads are served from
follower replicas.

Release note: None
Release justification: testing only

This commit expands the existing `follower-reads` roachtest with four new variants:
- `follower-reads/survival=region/locality=global/reads=bounded-staleness`
- `follower-reads/survival=region/locality=regional/reads=bounded-staleness`
- `follower-reads/survival=zone/locality=global/reads=bounded-staleness`
- `follower-reads/survival=zone/locality=regional/reads=bounded-staleness`

As the names indicate, these four variants perform bounded staleness reads
over different cluster topologies and assert that the reads are served from
follower replicas.

Release note: None
Release justification: testing only
@nvb nvb requested review from a team and otan August 27, 2021 19:30
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Aug 29, 2021

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 30, 2021

Build succeeded:

@craig craig bot merged commit 6f1e7e8 into cockroachdb:master Aug 30, 2021
@nvb nvb deleted the nvanbenschoten/boundedStalenessRoachtest branch September 7, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants