kv: specify + test behavior of NegotiateAndSend with paginated reads#69481
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 30, 2021
Merged
Conversation
Member
|
This change is |
otan
approved these changes
Aug 29, 2021
Fixes cockroachdb#69386. In cockroachdb#69350, we began relying on the previously unspecified behavior of Txn.NegotiateAndSend that negotiation was completed across all read spans in a request, even if the request itself was paginated. This commit clarifies this contract. It also adds client and server-side tests that exercise the behavior. Release justification: added testing for new functionality
8790eb0 to
84ce692
Compare
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69386.
In #69350, we began relying on the previously unspecified behavior of
Txn.NegotiateAndSend that negotiation was completed across all read
spans in a request, even if the request itself was paginated. This
commit clarifies this contract. It also adds client and server-side
tests that exercise the behavior.
Release justification: added testing for new functionality