kvfollowerreadsccl: version gate bounded staleness reads#69351
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 26, 2021
Merged
kvfollowerreadsccl: version gate bounded staleness reads#69351craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
02a4fed to
7020c59
Compare
nvb
approved these changes
Aug 25, 2021
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/ccl/kvccl/kvfollowerreadsccl/boundedstaleness.go, line 27 at r2 (raw file):
func checkBoundedStalenessEnabled(ctx *tree.EvalContext) error { st := ctx.Settings if !ctx.Settings.Version.IsActive(ctx.Ctx(), clusterversion.BoundedStaleness) {
nit: s/ctx.Settings/st/
1745af2 to
9128da5
Compare
Contributor
Author
|
bors r=nvanbenschoten |
Contributor
|
bors r- Merge conflict with master. |
Contributor
|
Canceled. |
Contributor
Author
|
bors' approach to merge conflict (split PRs apart and try again) seems terrifyingly slow; merge conflicts are cheaper to detect than splitting in half and going through a CI run. sigh. thanks for the pickup |
Contributor
Author
|
bors r=nvanbenschoten |
Contributor
Author
|
bors r- |
Contributor
|
Canceled. |
Release justification: testing only change Release note: None
Contributor
Author
|
bors r=nvanbenschoten |
Release justification: fix for new functionality Release note: None
Contributor
|
Canceled. |
Contributor
Author
|
bors r=nvanbenschoten |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits for details
resolves #69347
Release justification: fix for new functionality