sql: no-op interleaved syntax for CREATE TABLE/INDEX#69304
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 27, 2021
Merged
sql: no-op interleaved syntax for CREATE TABLE/INDEX#69304craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
b87d8d8 to
92a8a79
Compare
ajwerner
approved these changes
Aug 27, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
pkg/sql/create_index.go, line 616 at r1 (raw file):
// tables are disabled, or sends a notice, if they're not. Returns any error // and if the interleaved option should be ignored. func interleavedTableDeprecationAction(params runParams) (bool, error) {
nit: name the return value. We should always name boolean returns, otherwise it's hard to tell exactly what they mean from a quick glance.
b9cf058 to
9436a95
Compare
Collaborator
Author
|
bors r=ajwerner |
Collaborator
Author
|
bors r- |
Contributor
|
Canceled. |
Fixes: cockroachdb#68344 Previously, CREATE TABLE/INDEX operations were completely blocked with an error once support was removed. This was inadequate because for migrations may still use this syntax and we can't fully block it. To address this, this patch will make the interleaved syntax a no-op with a client warning. Release justification: low risk and saner behaviour for customer migrations on this release. Release note (sql change): Interleaved syntax for CREATE TABLE/INDEX is now a no-op, since support has been removed.
9436a95 to
fbb6bf0
Compare
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #68344
Previously, CREATE TABLE/INDEX operations were completely
blocked with an error once support was removed. This
was inadequate because for migrations may still use this
syntax and we can't fully block it. To address this, this
patch will make the interleaved syntax a no-op with a client
warning.
Release justification: low risk and saner behaviour for customer
migrations on this release.
Release note (sql change): Interleaved syntax for CREATE TABLE/INDEX
is now a no-op, since support has been removed.