changefeedccl: small test changes#69294
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 24, 2021
Merged
Conversation
Two small test changes: - Use log.TestingClearServerIdentifiers() to avoid opening a new log scope. - Don't start a schema registry when the kafka sink will already start one for us. Release justification: low risk, test only changes (category 1) Release note: None
Member
|
This change is |
HonoreDB
approved these changes
Aug 24, 2021
Contributor
HonoreDB
left a comment
There was a problem hiding this comment.
It's the /format=avro part of the test setup that starts the schema registry, not kafka, I hope? I don't remember. But we do support avro for most other sinks.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
miretskiy
approved these changes
Aug 24, 2021
Contributor
miretskiy
left a comment
There was a problem hiding this comment.
Currently -- only kafka if you're using test feeds.
Reviewable status:
Collaborator
Author
|
TFTR. Yup it is only kafka that has that magic, but the tests I'm changing just run on Kafka right now. bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small test changes:
Use log.TestingClearServerIdentifiers() to avoid opening a new log
scope.
Don't start a schema registry when the kafka sink will already start
one for us.
Release justification: low risk, test only changes (category 1)
Release note: None