logictestccl: avoid static identifiers for enums#69225
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 23, 2021
Merged
logictestccl: avoid static identifiers for enums#69225craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
approved these changes
Aug 23, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajstorm and @arulajmani)
Contributor
Author
|
thanks! bors r=ajwerner |
Contributor
Author
|
bors r- release justifications begin... |
Contributor
|
Canceled. |
Contributor
Author
|
bors r=ajwerner |
Contributor
|
Build failed: |
We cannot rely on an enum having a static ID in logic tests. As such, rework tests that rely on having a static ID. Release justification: test only change Release note: None
Contributor
Author
|
bors r=ajwerner |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot rely on an enum having a static ID in logic tests. As such,
rework tests that rely on having a static ID.
Resolves #67869
Release justification: test only change
Release note: None