ci: add bazel bench job#69166
Merged
Merged
Conversation
Member
|
This change is |
e27f6a3 to
85d4218
Compare
Contributor
Author
1043d1c to
eae33bc
Compare
rail
approved these changes
Aug 20, 2021
rail
left a comment
Member
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 6 of 6 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
build/teamcity/cockroach/ci/tests/bench_impl.sh, line 7 at r1 (raw file):
# Enumerate test targets that have benchmarks. all_tests=$(bazel query 'kind(go_test, //pkg/...)' --output=label) pkgs=$(git grep -l '^func Benchmark' -- 'pkg/*_test.go' | rev | cut -d/ -f2- | rev | sort | uniq)
A nit. sort -ru replaces rev and uniq. (I know, this is the same commit, but in multiple PRs. The UI doesn't make it easy to figure out which one is which).
Also tweak `dev` to pass some necessary flag for benches, and fix some broken benchmarks. Closes #67140. Release note: None
Contributor
Author
|
bors r=rail |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tweak
devto pass some necessary flag for benches, and fix somebroken benchmarks.
Closes #67140.
Release note: None