logic_test/as_of: deflake test#69062
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 18, 2021
Merged
Conversation
Logic tests randomize column families, and in the case of bounded staleness results in multi-batch fetches in the execution layer calling NegotiateAndSend, which means they could get different bounded staleness results. To alleviate the flaky tests for now, we set the same family for the given table. Release note: None
Member
|
This change is |
Contributor
Author
|
i've filed #69063 to follow up, just want to deflake it for now |
nvb
approved these changes
Aug 18, 2021
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
Contributor
Author
|
thanks! bors r=nvanbenschoten enjoy your time off |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic tests randomize column families, and in the case of bounded
staleness results in multi-batch fetches in the execution layer calling
NegotiateAndSend, which means they could get different bounded staleness
results. To alleviate the flaky tests for now, we set the same family
for the given table.
Release note: None