kv: return error from checkNegotiateAndSendPreconditions#69046
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 28, 2021
Merged
kv: return error from checkNegotiateAndSendPreconditions#69046craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
approved these changes
Aug 17, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten and @otan)
pkg/kv/txn.go, line 1122 at r1 (raw file):
Quoted 5 lines of code…
err := errors.AssertionFailedf("%s: ba=%s, txn=%s", s, ba.String(), txn.String()) err = errors.WithContextTags(err, ctx) panic(err) }
You could just do a CombineErrors here and avoid the nil check. Probably not a bad idea to accumulate all of the ways in which expectations were violated.
otan
approved these changes
Aug 17, 2021
8182035 to
2e3a584
Compare
2e3a584 to
6abf81e
Compare
Instead of panicking. Discussed in cockroachdb#68969. Release justification: change to new functionality
6abf81e to
ab8bb0a
Compare
Contributor
Author
|
bors r+ |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of panicking. Discussed in #68969.
Release justification: change to new functionality