roachtest/tests/cdc: effectively disable exponential backoff in jobs#69034
Conversation
Fixes cockroachdb#68963. Release note: None
|
This change is |
sajjadrizvi
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
sajjadrizvi
left a comment
There was a problem hiding this comment.
Sorry for commenting after approving. It just occurred to me that if we want to disable backoff, why not set both initial delay and max delay to longer than test timeout, e.g., a minute?
Reviewable status:
I don't understand. Can you explain how this would help fix this test which is broken because the job is not being resumed in a timely manner in the face of chaos? |
sajjadrizvi
left a comment
There was a problem hiding this comment.
The title says "... effectively disable exponential backoff", so I thought we want to disable retries completely.
Reviewable status:
ajwerner
left a comment
There was a problem hiding this comment.
The title says "... effectively disable exponential backoff", so I thought we want to disable retries completely.
It does not say disable retries, it says disable backoff.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Fixes #68963.
Release note: None