colexec: fix bytes corruption for disk-spilled window functions#69024
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 17, 2021
Merged
colexec: fix bytes corruption for disk-spilled window functions#69024craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This patch fixes the `Truncate` method for bytes columns so that it updates the offsets to be non-decreasing up to the new `maxSetLength`. This is necessary in the case when the new `maxSetLength` is greater than the old one. This can happen when a window function has a bytes output column and the `SpillingQueue` that buffers input batches spills to disk. If a batch has trailing nulls up to the last processed index, and it is immediately enqueued to disk, `SpillingQueue` does not call `SetLength` on the batch, so the offsets still need to be updated (in this case by `Truncate`). Fixes cockroachdb#60824 Release note: None
Member
|
This change is |
yuzefovich
approved these changes
Aug 17, 2021
Member
yuzefovich
left a comment
There was a problem hiding this comment.
:plause: for figuring out the end-to-end regression test!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
Collaborator
Author
|
TFTR! |
Collaborator
Author
|
Bazel failure looks like an unrelated test timout. |
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the
Truncatemethod for bytes columns so that itupdates the offsets to be non-decreasing up to the new
maxSetLength.This is necessary in the case when the new
maxSetLengthis greaterthan the old one.
This can happen when a window function has a bytes output column and
the
SpillingQueuethat buffers input batches spills to disk. If abatch has trailing nulls up to the last processed index, and it is
immediately enqueued to disk,
SpillingQueuedoes not callSetLengthon the batch, so the offsets still need to be updated (in this case by
Truncate).Fixes #60824
Release note: None