Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @otan and @pawalt)

pkg/sql/create_database.go, line 100 at r1 (raw file):

		if !p.EvalContext().SessionData.PlacementEnabled {
			return nil, pgerror.New(
				pgcode.InvalidDatabaseDefinition,

Feature not supported instead, maybe?

pkg/sql/create_database.go, line 101 at r1 (raw file):

			return nil, pgerror.New(
				pgcode.InvalidDatabaseDefinition,

extra line?

pkg/sql/create_database.go, line 102 at r1 (raw file):

				pgcode.InvalidDatabaseDefinition,

				"PLACEMENT requires that the cluster setting sql.defaults.experimental_placement "+

Should we be referencing the session setting here instead as the cluster setting only serves as a default?

Also, let's put the exact session setting that the user might need to change in the HINT message. It's nice to have these things copy-paste-able.

pkg/sql/exec_util.go, line 236 at r1 (raw file):

var placementEnabledClusterMode = settings.RegisterBoolSetting(
	"sql.defaults.experimental_placement.enabled",

Let's call this sql.defaults.multiregion_placement_policy.enabled?

Last I heard we were moving away from "experimental" in cluster settings/syntax etc.

pkg/sql/vars.go, line 1258 at r1 (raw file):

	// CockroachDB extension.
	`experimental_enable_placement`: {

Same as above, instead of experimental_enable_placement, let's call this enable_multiregion_placement_policy instead.

pkg/sql/sessiondatapb/local_only_session_data.proto, line 170 at r1 (raw file):

  // PlacementEnabled indicates whether PLACEMENT can be used or not.
  bool placement_enabled = 44;

Why do we need this?

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @otan)

pkg/sql/create_database.go, line 100 at r1 (raw file):

Done.

pkg/sql/create_database.go, line 101 at r1 (raw file):

Done.

pkg/sql/create_database.go, line 102 at r1 (raw file):

I'll put the session setting in the main error and cluster setting in the hint so they know where to go for long-term changes.

pkg/sql/exec_util.go, line 236 at r1 (raw file):

Done.

pkg/sql/vars.go, line 1258 at r1 (raw file):

Done.

pkg/sql/sessiondatapb/local_only_session_data.proto, line 170 at r1 (raw file):

@otan moved our session setting from an enum to proto, so we've gotta add this here.

once the commit message is updated

Reviewed 1 of 13 files at r1, 1 of 1 files at r2, 11 of 11 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan and @pawalt)

-- commits, line 6 at r3 ([raw file](https://github.com/cockroachdb/cockroach/blob/77c6806264161af6dddd888948e3239d82748e82/-- commits#L6)):
I think your commit message needs an update with the new session/cluster settings in.

Also, add a nod to the fact that you're intentionally skipping on the release note here and why.

pkg/sql/create_database.go, line 102 at r1 (raw file):

Maybe I'm lazy, but I really like when I can just copy paste the exact session setting I need to change instead of deciphering a hint message. Maybe something like "you can enable multi-region placement policy by running SET enable_multiregion_placement_policy = true in the hint.

Your call!

pkg/sql/sessiondatapb/local_only_session_data.proto, line 170 at r1 (raw file):

TIL!

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @arulajmani and @otan)

-- commits, line 6 at r3 ([raw file](https://github.com/cockroachdb/cockroach/blob/77c6806264161af6dddd888948e3239d82748e82/-- commits#L6)):

Done.

pkg/sql/create_database.go, line 102 at r1 (raw file):

Makes sense!