kvserver: deflake TestNonVoterCatchesUpViaRaftSnapshotQueue#68642
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 10, 2021
Conversation
Fixes cockroachdb#68142 Release note: None
Member
|
This change is |
Contributor
Author
|
FWIW the failure seems really rare and I haven't been able to repro a failure with or without this patch on a really beefy The test history for this test also seems to indicate that the flake is really rare. I do think this patch should eliminate the flake we saw in #68142 though. |
erikgrinaker
approved these changes
Aug 10, 2021
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Yeah, this is likely very rare. Thanks!
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68142
Release note: None