kvserver/closedts: fix nil dereference in HTML generation#68637
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 10, 2021
Merged
kvserver/closedts: fix nil dereference in HTML generation#68637craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The `/debug/closedts-{sender,receiver}` endpoints could panic due to a
nil dereference if the last update in the sidetransport buffer was
removed by the time it was rendered. This patch adds a `nil` check to
avoid that panic.
Release note (bug fix): Fixed a crash in the
`/debug/closedts-{sender,receiver}` advanced debug pages if the last
message of the closed timestamp side transport buffer was removed before
rendering.
Member
|
This change is |
aliher1911
approved these changes
Aug 10, 2021
Contributor
aliher1911
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
Contributor
Author
|
bors r=aliher1911 |
Contributor
|
Build failed: |
Contributor
Author
|
bors r=aliher1911 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/debug/closedts-{sender,receiver}endpoints could panic due to anil dereference if the last update in the sidetransport buffer was
removed by the time it was rendered. This patch adds a
nilcheck toavoid that panic.
Release note (bug fix): Fixed a crash in the
/debug/closedts-{sender,receiver}advanced debug pages if the lastmessage of the closed timestamp side transport buffer was removed before
rendering.