server: reduce flakiness of TestEnsureSQLStatsAreFlushedForTelemetry#68614
server: reduce flakiness of TestEnsureSQLStatsAreFlushedForTelemetry#68614craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @Azhng)
-- commits, line 8 at r1 ([raw file](https://github.com/cockroachdb/cockroach/blob/d63db558b979e9e7d3846892b1995c6fa337651a/-- commits#L8)):
nit: the wording here is a little confusing. You mean the new cases should NOT cause collision?
d63db55 to
a53a8c1
Compare
Azhng
left a comment
There was a problem hiding this comment.
Reviewable status:
-- commits, line 8 at r1 ([raw file](https://github.com/cockroachdb/cockroach/blob/d63db558b979e9e7d3846892b1995c6fa337651a/-- commits#L8)):
Previously, maryliag (Marylia Gutierrez) wrote…
nit: the wording here is a little confusing. You mean the new cases should NOT cause collision?
Done.
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
-- commits, line 8 at r1 ([raw file](https://github.com/cockroachdb/cockroach/blob/d63db558b979e9e7d3846892b1995c6fa337651a/-- commits#L8)):
Previously, Azhng (Archer Zhang) wrote…
Done.
Can you update on the PR description too?
Azhng
left a comment
There was a problem hiding this comment.
Reviewable status:
-- commits, line 8 at r1 ([raw file](https://github.com/cockroachdb/cockroach/blob/d63db558b979e9e7d3846892b1995c6fa337651a/-- commits#L8)):
Previously, maryliag (Marylia Gutierrez) wrote…
Can you update on the PR description too?
Oops forgot to hit the "Update" button
Previously, this unit tests generates statements with the fingerprint 'INSERT INTO _ VALUES (_)'. However, this is a very common fingerprint and can collide with actual statements issued by other subsystems, which in turn cause test failure. This commit change the test cases to use uncommon statements that should not cause fingerprint collision Resolves cockroachdb#66826 Release note: None
a53a8c1 to
f2bf9b3
Compare
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
|
TFTR! bors r+ |
|
bors r+ |
|
Build succeeded: |
Previously, this unit tests generates statements with the fingerprint
'INSERT INTO _ VALUES (_)'. However, this is a very common fingerprint
and can collide with actual statements issued by other subsystems, which
in turn cause test failure.
This commit change the test cases to use uncommon statements that should
not cause fingerprint collision
Resolves #66826
Release note: None