admission: enable admission control#68535
Conversation
|
This change is |
|
this is just to get a full run of unit tests and roachtests on CI |
|
If this passes basic tests, LGTM to merge and then revert Monday. Add annotations to roachperf like this: https://github.com/cockroachdb/roachperf/commit/7abd2af2bf5109376581c299c1a4a47f11354ee3 |
7251e10 to
1a77cff
Compare
|
We should merge this soon. Along with it, won't we need to update the roachtests? The |
1a77cff to
7a7e4a7
Compare
sumeerbhola
left a comment
There was a problem hiding this comment.
Along with it, won't we need to update the roachtests? The AdmissionControlEnabled flag would become a no-op, seems like we'd want to invert it and have some "noadmission" variants for a few tests.
Done
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @RaduBerinde)
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
Also updated existing roachtests that explicitly enabled admission control to now disable admission control, so that we can continue to compare performance of the two settings. Release note (ops change): The cluster settings affecting the admission control system enablement are now set to defaults that enable admission control.
7a7e4a7 to
7e5741b
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Also updated existing roachtests that explicitly enabled
admission control to now disable admission control, so
that we can continue to compare performance of the two
settings.
Release note (ops change): The cluster settings affecting
the admission control system enablement are now set to
defaults that enable admission control.