kv: include RangeID in rangefeed goroutine stacks#68442
kv: include RangeID in rangefeed goroutine stacks#68442craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
erikgrinaker
left a comment
There was a problem hiding this comment.
Thanks, this'll be useful!
This commit includes the RangeID in each of a rangefeed processor and its registations' associated goroutine stacks. This is a cheap and easy way to get better observability into the ranges that have active rangefeeds. It also tells us where those goroutines are spending their time. This will also become easier to use in Go 1.17, which improved the format of stack traces.
f5088a5 to
1306da5
Compare
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 1306da5 to blathers/backport-release-20.2-68442: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 20.2.x failed. See errors above. error creating merge commit from 1306da5 to blathers/backport-release-21.1-68442: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit includes the RangeID in each of a rangefeed processor and
its registations' associated goroutine stacks. This is a cheap and easy
way to get better observability into the ranges that have active
rangefeeds. It also tells us where those goroutines are spending their
time.
This will also become easier to use in Go 1.17, which improved the
format of stack traces.