roachtest: avoid releasing alloc multiple times#68203
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 29, 2021
Merged
roachtest: avoid releasing alloc multiple times#68203craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
As of cockroachdb#68103, existing problems in the cluster creation retry logic are tickled reliably: on retry we are releasing an alloc twice, resulting in a panic. Unfortunately, the alloc is acquired several layers above the retry, so for now the best I can do is to avoid releasing the alloc if we are bound for a retry. The reason the above PR tickles it more reliably is because it accidentally removed a sensible failfast: when the cluster already exists, we shouldn't destroy & try to recreate it again (which would then explode on the double-release anyway). Release note: None
Member
Author
|
I "tested" this by adding a |
erikgrinaker
approved these changes
Jul 29, 2021
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
I share your reluctance about this approach, but I guess it gets the job done for now.
Member
Author
|
bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #68103, existing problems in the cluster creation retry logic
are tickled reliably: on retry we are releasing an alloc twice,
resulting in a panic. Unfortunately, the alloc is acquired several
layers above the retry, so for now the best I can do is to avoid
releasing the alloc if we are bound for a retry.
The reason the above PR tickles it more reliably is because it
accidentally removed a sensible failfast: when the cluster already
exists, we shouldn't destroy & try to recreate it again (which
would then explode on the double-release anyway).
Release note: None