roachtest: fix replicagc-changed-peers (again)#68156
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 29, 2021
Merged
roachtest: fix replicagc-changed-peers (again)#68156craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
I wrote buggy code. Since it isn't hit in every invocation, it slipped through my local testing. Fixes cockroachdb#68155 Release note: None
Member
|
This change is |
Member
Author
|
Going to run this with a modified version of the code where we always produce some rows at least a few times, to check that it now actually works. |
erikgrinaker
approved these changes
Jul 28, 2021
Member
Author
|
The good news is - this new code works. The bad news is, the test legit fails at this point: Still going to merge this, as it does fix the test, though not the problem the test finds. bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote buggy code. Since it isn't hit in every invocation, it slipped
through my local testing.
Fixes #68155
Fixes #68162
Release note: None