sqlproxy: fix test flake#67735
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 20, 2021
Merged
Conversation
Member
|
This change is |
jaylim-crl
reviewed
Jul 18, 2021
Contributor
jaylim-crl
left a comment
There was a problem hiding this comment.
LGTM, but we should remove those generated and pprof files that were checked in.
Reviewed 1 of 25 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chrisseto)
chrisseto
reviewed
Jul 19, 2021
Contributor
chrisseto
left a comment
There was a problem hiding this comment.
Reviewable status:
TestDirectoryConnect is flaking when testing that it has only one connection to the proxy. This flake happens because it takes time for connection closure to propagate to the server. The connection from the previous sub-test is still present. The fix is to use require.Eventually to wait until the previous connection is torn down. Fixes cockroachdb#67405 Release note: None
jaylim-crl
approved these changes
Jul 19, 2021
Contributor
jaylim-crl
left a comment
There was a problem hiding this comment.
Reviewed 24 of 24 files at r2.
Reviewable status:
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDirectoryConnect is flaking when testing that it has only one connection
to the proxy. This flake happens because it takes time for connection
closure to propagate to the server. The connection from the previous
sub-test is still present. The fix is to use require.Eventually to wait
until the previous connection is torn down.
Fixes #67405
Release note: None