colrpc: minor cleanup#67663
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jul 20, 2021
Merged
Conversation
Member
|
This change is |
michae2
approved these changes
Jul 19, 2021
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
This simplifies the signature of the method a bit. Release note: None
This commit clarifies the usage of different contexts in a test since we use different contexts to simulate remote nodes as well as independent scenarios. Release note: None
f9262ff to
c27fa16
Compare
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts a couple of commits from #65586 which are not
controversial and seem beneficial in its own right.
colrpc: take in OpWithMetaInfo in the outbox constructor
This simplifies the signature of the method a bit.
Release note: None
colrpc: clarify a test a bit
This commit clarifies the usage of different contexts in a test since we
use different contexts to simulate remote nodes as well as independent
scenarios.
Release note: None