sql: require placeholder types to be identical to use a cached plan#67651
Merged
craig[bot] merged 1 commit intoJul 15, 2021
Merged
Conversation
Release note (bug fix): Fix a bug where a prepared statement could incorrectly reuse the query plan of a different prepared statements that had similar, but not identical type hints.
Member
|
This change is |
yuzefovich
reviewed
Jul 15, 2021
yuzefovich
left a comment
Member
There was a problem hiding this comment.
LGTM but I'll defer to @RaduBerinde for the approval.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
RaduBerinde
approved these changes
Jul 15, 2021
RaduBerinde
left a comment
Member
There was a problem hiding this comment.
Reviewable status:
Collaborator
Author
|
tftr! bors r=RaduBerinde |
Contributor
|
Build succeeded: |
This was referenced Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #67605
Release note (bug fix): Fix a bug where a prepared statement could
incorrectly reuse the query plan of a different prepared statements that
had similar, but not identical type hints.