parser: reduce imports for scan.go#67557
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jul 14, 2021
Merged
Conversation
Member
|
This change is |
104622e to
376bd07
Compare
This removes the dependency that scan.go has on pkg/sql/lex, and will make it possible to move scan.go to its own package. Release note: None
We now inject the NewNumVal and NewPlaceholder functions into scan.go. This lets us move scan.go into its own package. Release note: None
376bd07 to
209c5f0
Compare
otan
approved these changes
Jul 13, 2021
Collaborator
Author
|
tftr! bors r=otan |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
knz
reviewed
Jul 14, 2021
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits:
Touches #64710