catalogkv: fix panic inside Txn swallowing retries#67544
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 14, 2021
Merged
catalogkv: fix panic inside Txn swallowing retries#67544craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
postamar
approved these changes
Jul 13, 2021
postamar
left a comment
There was a problem hiding this comment.
This is very uncontroversial! Thanks for doing this.
`(*kv.DB).Txn` may produce retry errors. While it's fine that this test function can panic in the face of a real error, it's not okay to panic the retry error. Fixes cockroachdb#67213. Release note: None
5e58560 to
763d236
Compare
Contributor
Author
|
bors r=postamar |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(*kv.DB).Txnmay produce retry errors. While it's fine that this testfunction can panic in the face of a real error, it's not okay to panic
the retry error.
Fixes #67213.
Release note: None