limit,storage: add more trace spans to backup path#67524
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jul 14, 2021
Merged
limit,storage: add more trace spans to backup path#67524craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
0bb36ae to
7cd7c3d
Compare
dt
approved these changes
Jul 13, 2021
| const big = 1 << 30 | ||
| sstFile := &MemFile{} | ||
| _, _, err := e.ExportMVCCToSst(startKey, endKey, startTime, endTime, revisions, big, big, | ||
| _, _, err := e.ExportMVCCToSst(ctx, startKey, endKey, startTime, endTime, revisions, big, big, |
Contributor
There was a problem hiding this comment.
2¢: I think you could just context.Background here instead to eliminate a lot of the test diff churn 🤷
pkg/util/limit/limiter.go
Outdated
| var span *tracing.Span | ||
| ctx, span = tracing.ChildSpan(ctx, l.spanName) | ||
| defer span.Finish() | ||
| span.RecordStructured(&types.StringValue{Value: fmt.Sprintf("%d requests are waiting in the pool", l.sem.Len())}) |
Contributor
There was a problem hiding this comment.
nit: s/in the pool// (also, I could see this file being separate commit)
77abf73 to
3f09399
Compare
Release note: None
Release note: None
3f09399 to
fe57f71
Compare
Contributor
Author
|
TFTR! bors r=dt |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a trace recording to track how
many requests are waiting in the the concurrent limiter
queue.
The change also adds a child span to ExportMVCCToSst
to track how long the scan+SST creation is taking per
ExportRequest during backup.
Release note: None