Skip to content

roachtest: fix gorm by installing test deps#67393

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-gorm
Jul 9, 2021
Merged

roachtest: fix gorm by installing test deps#67393
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-gorm

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Jul 8, 2021

fixes #66825

I think this started failing with the move to go1.16.
I added these steps to match what gorm does in its own test suite.

Release note: None

@rafiss rafiss requested review from a team and RichardJCai July 8, 2021 22:13
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jul 8, 2021

tftr!

bors r=RichardJCai

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Build failed (retrying...):

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jul 9, 2021

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Canceled.

I think this started failing with the move to go1.16.
I added these steps to match what gorm does in its own test suite.

Release note: None
@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jul 9, 2021

bors r=RichardJCai

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Build succeeded:

@craig craig bot merged commit 21df275 into cockroachdb:master Jul 9, 2021
@rafiss rafiss deleted the fix-gorm branch July 19, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: gorm failed

3 participants