Skip to content

sql: store plan as jsonb in system.statement_statistics#67331

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
Azhng:sql-stats-json-plan
Jul 9, 2021
Merged

sql: store plan as jsonb in system.statement_statistics#67331
craig[bot] merged 1 commit intocockroachdb:masterfrom
Azhng:sql-stats-json-plan

Conversation

@Azhng
Copy link
Copy Markdown
Contributor

@Azhng Azhng commented Jul 7, 2021

Previously, we store statement plan as a byte blob column in
system.statement_statistics. As of #65782 we now support JSON
encoding for the plan.
This commit change the column type for plan from BYTES to JSONB
in system.statement_statistics.

Release note (sql change): using JSONB to store statement plan
instead of BYTES in system.statement_statistics.

Previously, we store statement plan as a byte blob column in
system.statement_statistics. As of cockroachdb#65782 we now support JSON
encoding for the plan.
This commit change the column type for plan from BYTES to JSONB
in system.statement_statistics.

Release note (sql change): using JSONB to store statement plan
 instead of BYTES in system.statement_statistics.
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@Azhng Azhng requested a review from a team July 7, 2021 23:57
@Azhng Azhng marked this pull request as ready for review July 7, 2021 23:57
@Azhng
Copy link
Copy Markdown
Contributor Author

Azhng commented Jul 7, 2021

cc: @kevin-v-ngo

Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@Azhng
Copy link
Copy Markdown
Contributor Author

Azhng commented Jul 8, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 8, 2021

Build failed (retrying...):

@Azhng
Copy link
Copy Markdown
Contributor Author

Azhng commented Jul 8, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 8, 2021

Already running a review

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 8, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 8, 2021

Build failed (retrying...):

@otan
Copy link
Copy Markdown
Contributor

otan commented Jul 9, 2021

bors r-

🚨 bors is busted 🚨

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Canceled.

@otan
Copy link
Copy Markdown
Contributor

otan commented Jul 9, 2021

bors r=maryliag

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 9, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants