Skip to content

bazel: correctly report target machine when stamping#67278

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:build-rev
Jul 6, 2021
Merged

bazel: correctly report target machine when stamping#67278
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:build-rev

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

Add functionality in stamp.sh to allow specifying or inferring the
build target from cc -dumpmachine.

Closes #66853.

Release note: None

Add functionality in `stamp.sh` to allow specifying or inferring the
build target from `cc -dumpmachine`.

Closes cockroachdb#66853.

Release note: None
@rickystewart rickystewart requested a review from rail July 6, 2021 16:52
@rickystewart rickystewart requested a review from a team as a code owner July 6, 2021 16:52
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@rickystewart
Copy link
Copy Markdown
Collaborator Author

bors r=rail

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 6, 2021

Build succeeded:

@craig craig bot merged commit be4dbf9 into cockroachdb:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bazel: augment build-rev.sh so that it reports correct info re: host triple, target triple, etc.

3 participants