roachtest: re-enable load-splitting for some kv tests#67107
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 5, 2021
Merged
roachtest: re-enable load-splitting for some kv tests#67107craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
In cockroachdb#58670 we overloaded `splits: -1` to also disable load-based splitting. This rather dramatically changes the req/sec these tests can achieve, producing worrying drops in our historical performance monitoring. This adds a new option for disabling load splitting so that we can keep the behaviour of the previous tests. Release note: None
Member
|
This change is |
tbg
approved these changes
Jul 2, 2021
Collaborator
Author
|
bors r=tbg |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #58670 we overloaded
splits: -1to also disable load-basedsplitting. This rather dramatically changes the req/sec these tests
can achieve, producing worrying drops in our historical performance
monitoring.
This adds a new option for disabling load splitting so that we can
keep the behaviour of the previous tests.
Release note: None