opt: add test to ensure Metadata.CopyFrom makes copies of table metadata maps#67078
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 30, 2021
Merged
Conversation
…ata maps This commit adds assertions to `TestMetadata` that ensure that `Metadata.CopyFrom` makes copies of computed column expression maps and parital index predicate maps in table metadata, rather than sharing the same underlying map. These tests would have caught the bug that was fixed in cockroachdb#66792. Release note: None
Member
|
This change is |
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds assertions to
TestMetadatathat ensure thatMetadata.CopyFrommakes copies of computed column expression maps andparital index predicate maps in table metadata, rather than sharing the
same underlying map. These tests would have caught the bug that was
fixed in #66792.
Release note: None