Skip to content

go.mod: update cloud.google.com/go/storage to v1.16.0#66993

Closed
adityamaru wants to merge 1 commit intocockroachdb:masterfrom
adityamaru:bump-google-sdk
Closed

go.mod: update cloud.google.com/go/storage to v1.16.0#66993
adityamaru wants to merge 1 commit intocockroachdb:masterfrom
adityamaru:bump-google-sdk

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

@adityamaru adityamaru commented Jun 29, 2021 •
edited
Loading

https://github.com/googleapis/google-cloud-go/releases/tag/storage%2Fv1.16.0 has the sought-after GOAWAY fix and is the latest release of the storage subpackage.

Release note: None

@adityamaru adityamaru requested a review from pbardea June 29, 2021 02:13
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 29, 2021

This change is Reviewable

@adityamaru
Copy link
Copy Markdown
Contributor Author

adityamaru commented Jun 29, 2021

The PR is likely going to run into make bazel_generate failing with:

ERROR: /private/var/tmp/_bazel_adityamaru/2592a7600a28e43d0b132c217219adf9/external/io_bazel_rules_go/BUILD.bazel:73:16: in go_context_data rule @io_bazel_rules_go//:go_context_data: cycle in dependency graph:
    //:gazelle
    //:gazelle-runner
    @bazel_gazelle//cmd/gazelle:gazelle
    @bazel_gazelle//language/go:go_default_library
    @bazel_gazelle//language/go:go
    @com_github_pelletier_go_toml//:go-toml
.-> @io_bazel_rules_go//:go_context_data
|   @io_bazel_rules_nogo//:nogo
|   @io_bazel_rules_go//:default_nogo
|   @io_bazel_rules_go//go/tools/builders:nogo_srcs
|   @org_golang_x_tools//go/analysis:go_tool_library
|   @org_golang_x_tools//internal/analysisinternal:go_tool_library
|   @org_golang_x_tools//go/ast/astutil:go_tool_library
|   @org_golang_x_tools//internal/typeparams:typeparams
`-- @io_bazel_rules_go//:go_context_data
ERROR: Analysis of target '//:gazelle' failed; build aborted

This looks similar to what #66880 is blocked on which is being tracked at bazel-contrib/rules_go#2479.

@adityamaru adityamaru mentioned this pull request Jun 29, 2021
Closed
6 tasks
@knz knz mentioned this pull request Jul 5, 2021
Merged
pbardea
pbardea approved these changes Jul 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (and took a look at the release notes); LGTM pending resolution of the Bazel blocker.

This was referenced Jul 8, 2021
Closed
Closed
@adityamaru adityamaru force-pushed the bump-google-sdk branch 2 times, most recently from 72cb820 to 102744a Compare July 16, 2021 16:57
@pbardea pbardea mentioned this pull request Jul 19, 2021
Closed
@adityamaru
Copy link
Copy Markdown
Contributor Author

adityamaru commented Jul 27, 2021

Replaced by #67806

@adityamaru adityamaru closed this Jul 27, 2021
@adityamaru adityamaru deleted the bump-google-sdk branch July 27, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pbardea pbardea pbardea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityamaru @cockroach-teamcity @pbardea