Skip to content

sql: added missing tables from mysql information_schema#66795

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
mnovelodou:information_schema_mysql
Jul 14, 2021
Merged

sql: added missing tables from mysql information_schema#66795
craig[bot] merged 1 commit intocockroachdb:masterfrom
mnovelodou:information_schema_mysql

Conversation

@mnovelodou
Copy link
Copy Markdown
Contributor

@mnovelodou mnovelodou commented Jun 23, 2021

Previously, there was missing tables on information_schema present on
mysql
This was inadequate because it can cause compatibility problems
To address this, this patch adds missing information_schema tables

Release note (sql change): Added missing tables from mysql
information_schema. The tables are not populated and are
entirely empty.

  • column_statistics
  • columns_extensions
  • engines
  • events
  • files
  • keywords
  • optimizer_trace
  • partitions
  • plugins
  • processlist
  • profiling
  • resource_groups
  • schemata_extensions
  • st_geometry_columns
  • st_spatial_reference_systems
  • st_units_of_measure
  • table_constraints_extensions
  • tables_extensions
  • tablespaces
  • tablespaces_extensions
  • user_attributes

@mnovelodou mnovelodou requested a review from rafiss June 23, 2021 20:57
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 23, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jun 23, 2021
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@mnovelodou mnovelodou force-pushed the information_schema_mysql branch from 8b014dd to a9e47e7 Compare June 23, 2021 22:38
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 23, 2021

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@mnovelodou mnovelodou force-pushed the information_schema_mysql branch from a9e47e7 to d4f41d0 Compare July 12, 2021 18:47
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i just noticed one change we should make to the release note. can it say:

"Added missing tables from mysql information_schema. The tables are not populated and are
entirely empty.

(add list of tables here)"

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mnovelodou)

@mnovelodou mnovelodou force-pushed the information_schema_mysql branch from d4f41d0 to fafa2b4 Compare July 13, 2021 22:26
Previously, there was missing tables on information_schema present on
mysql
This was inadequate because it can cause compatibility problems
To address this, this patch adds missing information_schema tables

Release note (sql change): Added missing tables from mysql
information_schema. The tables are not populated and are
entirely empty.

- column_statistics
- columns_extensions
- engines
- events
- files
- keywords
- optimizer_trace
- partitions
- plugins
- processlist
- profiling
- resource_groups
- schemata_extensions
- st_geometry_columns
- st_spatial_reference_systems
- st_units_of_measure
- table_constraints_extensions
- tables_extensions
- tablespaces
- tablespaces_extensions
- user_attributes
@mnovelodou mnovelodou force-pushed the information_schema_mysql branch from fafa2b4 to e0cdc5e Compare July 13, 2021 22:47
@mnovelodou mnovelodou requested a review from rafiss July 13, 2021 22:47
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the change!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 14, 2021

Build failed (retrying...):

@craig craig bot merged commit 5a0b11e into cockroachdb:master Jul 14, 2021
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 14, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-community Originated from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants