Skip to content

internal/sqlsmith: skip TestGenerateParse#66736

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:skip-test-TestGenerateParse
Jun 23, 2021
Merged

internal/sqlsmith: skip TestGenerateParse#66736
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:skip-test-TestGenerateParse

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Jun 22, 2021

Refs: #66723

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

@jbowens jbowens requested a review from mgartner June 22, 2021 21:33
@jbowens jbowens requested a review from a team as a code owner June 22, 2021 21:33
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 22, 2021

This change is Reviewable

@jbowens jbowens requested a review from nkodali June 22, 2021 21:34
RaduBerinde
RaduBerinde approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @nkodali)

jbowens
jbowens commented Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @nkodali)

mgartner
mgartner approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgartner mgartner mentioned this pull request Jun 22, 2021
Merged
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 22, 2021

Build failed (retrying...):

@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 22, 2021

bors r+

p=999

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 22, 2021

Already running a review

@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 22, 2021

bors cancel

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 22, 2021

Canceled.

@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 22, 2021

bors r+ p=999

@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 22, 2021

bors cancel

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 22, 2021

Canceled.

@jbowens @mgartner
internal/sqlsmith: skip TestGenerateParse
a3815dd 
Refs: cockroachdb#66723

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@mgartner mgartner force-pushed the skip-test-TestGenerateParse branch from 8b2d79a to a3815dd Compare June 22, 2021 23:15
@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 22, 2021

I updated the commit to include necessary bazel changes.

bors r+ p=999

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 23, 2021

Build failed:

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Jun 23, 2021

bors r+ p=999

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Jun 23, 2021

I updated the commit to include necessary bazel changes.

Thanks, missed the -under_bazel flag

@mgartner
Copy link
Copy Markdown
Contributor

mgartner commented Jun 23, 2021

I don't think the -under_bazel flag updates BUILD.bazel files. It uses the skip.UnderBazelWithIssue skipper instead of skip.WithIssue.

I've updated the skip-test utility to update BUILD.bazel files in #66745.

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 23, 2021

Build succeeded:

@craig craig bot merged commit 3b8b689 into cockroachdb:master Jun 23, 2021
@jbowens jbowens deleted the skip-test-TestGenerateParse branch June 23, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaduBerinde RaduBerinde RaduBerinde approved these changes

@nkodali nkodali Awaiting requested review from nkodali

+1 more reviewer

@mgartner mgartner mgartner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbowens @cockroach-teamcity @mgartner @RaduBerinde