storage/cloud: remove CloseWithError#65660
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2021
Merged
Conversation
Member
|
This change is |
miretskiy
approved these changes
May 25, 2021
Contributor
miretskiy
left a comment
There was a problem hiding this comment.
Reviewed 14 of 17 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru)
Context cancellation is typically how operations are aborted. When we open a new Writer, we pass a context, so we must assume that that context can be cancelled, which should cancel the write operation. Having an extra CloseWithError method in the API that also cancels the operation is duplicative. Release note: none.
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context cancellation is typically how operations are aborted.
When we open a new Writer, we pass a context, so we must assume
that that context can be cancelled, which should cancel the write
operation. Having an extra CloseWithError method in the API that
also cancels the operation is duplicative.
Release note: none.