opt: assert that ConstExpr do not wrap booleans#65638
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 24, 2021
Merged
opt: assert that ConstExpr do not wrap booleans#65638craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit adds a `memo.CheckExpr` assertion that panics during a test build if a true or false value are wrapped in a `ConstExpr`. Several rules assume that this invariant is held in order to make matching easier. The assertion revealed two cases which violated this invariant. Both have been fixed. Fixes cockroachdb#56253 Release note: None
Member
|
This change is |
rytaft
approved these changes
May 24, 2021
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Contributor
Author
|
Thanks for the review. bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
memo.CheckExprassertion that panics during a testbuild if a true or false value are wrapped in a
ConstExpr. Severalrules assume that this invariant is held in order to make matching
easier.
The assertion revealed two cases which violated this invariant. Both
have been fixed.
Fixes #56253
Release note: None