cli: default "--join" flag port to 26257#65014
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 12, 2021
Merged
Conversation
Member
|
This change is |
knz
approved these changes
May 12, 2021
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rauchenstein)
pkg/cli/flags_test.go, line 909 at r1 (raw file):
expectedJoin []string }{ {[]string{"connect", "--join=a"}, []string{"a:" + base.DefaultPort}},
since you authored this, the name of the command has changed to be connect init (or alternatively connect join). Two strings. Hence the test failure in CI.
a84f19b to
d7a734e
Compare
This behavior existed for "start --join" but not for "connect --join". (Our code didn't set a default, so it defaulted to port 443 for https.) The change is implemented at the level of flag parsing, so it is now uniform for all commands using the join flag. Fixes cockroachdb#61620. Release note (bug fix): Hosts listed with the "connect --join" command line flag now default to port 26257 (was 443). This matches the existing behavior of "start --join".
d7a734e to
96880bc
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior existed for "start --join" but not for "connect --join".
(Our code didn't set a default, so it defaulted to port 443 for https.)
The change is implemented at the level of flag parsing, so it is now
uniform for all commands using the join flag.
Fixes #61620.
Release note (bug fix): Hosts listed with the "connect --join" command
line flag now default to port 26257 (was 443). This matches the
existing behavior of "start --join".