security: accept CA keys in either PKCS#1 or PKCS#8 encodings#64943
Draft
knz wants to merge 1 commit intocockroachdb:masterfrom
Draft
security: accept CA keys in either PKCS#1 or PKCS#8 encodings#64943knz wants to merge 1 commit intocockroachdb:masterfrom
knz wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
25 tasks
aaron-crl
reviewed
May 11, 2021
aaron-crl
left a comment
There was a problem hiding this comment.
Approach looks good.
I'd be happy to see a light unit test in the security package here for this with a static pair of test certs. E2E would be good too but shouldn't block this.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @bdarnell)
Contributor
|
It looks like I think we already have a function for this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64942.
NB: I am not sure at which location I should implement a unit test for this. MY original goal was to create an end-to-end integration test for
cockroach connect join, and this catches it immediately. However, maybe we can make a unit test that's smaller in scope?Taking suggestions.